Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localize(None) for timezone-naive columns #13603

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Fix localize(None) for timezone-naive columns #13603

merged 5 commits into from
Jun 22, 2023

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Jun 21, 2023

Closes #13601

@github-actions github-actions bot added the Python Affects Python cuDF API. label Jun 21, 2023
@shwina shwina added non-breaking Non-breaking change bug Something isn't working labels Jun 21, 2023
@shwina shwina marked this pull request as ready for review June 22, 2023 17:24
@shwina shwina requested a review from a team as a code owner June 22, 2023 17:24
bdice
bdice approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise LGTM.

@shwina @bdice
Update python/cudf/cudf/core/_internals/timezones.py
42c1751 
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
@galipremsagar
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 0846494 into rapidsai:branch-23.08 Jun 22, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@galipremsagar galipremsagar galipremsagar approved these changes

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] sr.dt.tz_localize(None) fails on DatetimeColumn
3 participants
@shwina @galipremsagar @bdice