Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use get_current_device_resource for intermediate allocations in COLLECT_LIST window code #12927

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Use get_current_device_resource for intermediate allocations in COLLECT_LIST window code #12927

merged 1 commit into from
Mar 13, 2023

Conversation

karthikeyann
Copy link
Contributor

Description

Updated code to use defaulted argument get_current_device_resource() for intermediate allocations in COLLECT_LIST window code
one-line fix.
Fixes #8219

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added bug Something isn't working 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. tech debt non-breaking Non-breaking change labels Mar 13, 2023
@karthikeyann karthikeyann requested a review from a team as a code owner March 13, 2023 07:34
@karthikeyann
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ec746cf into rapidsai:branch-23.04 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@ttnghia ttnghia ttnghia approved these changes

@davidwendt davidwendt davidwendt approved these changes

@hyperbolic2346 hyperbolic2346 Awaiting requested review from hyperbolic2346 hyperbolic2346 is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@elstehle elstehle Awaiting requested review from elstehle elstehle is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] COLLECT_LIST window code uses wrong memory_resource for intermediate allocations
4 participants
@karthikeyann @mythrocks @ttnghia @davidwendt