-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize set-like operations #12769
Optimize set-like operations #12769
Conversation
This reverts commit 3781a00.
Benchmark comparing before vs after this PR:
|
Are the performance regression in several test cases expected? |
Yes. Previously, only a trivial check But sacrificing the performance regression in those cases can improve more performance in some other cases so this can be considered as an "improvement". Edit: Such (small) performance regression may be due to noise, as you can see some regression in cases even the input doesn't have nulls. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one open request about getting rid of an unnecessary enum and just using a lambda, but since that got a 👍 I'm approving assuming that change will happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One non-blocking suggestion.
LGTM
Co-authored-by: Yunsong Wang <wangyunsong89@gmail.com>
/merge |
Set-like operations such as
intersect_distinct
anddifference_distinct
callpurge_nonempty_nulls
when the input is nullable. This PR optimizes these set APIs by checking the existence of non-empty nulls (usinghas_nonempty_nulls
) before calling topurge_nonempty_nulls
.