-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove isort exclusions #11680
Remove isort exclusions #11680
Conversation
Seems like there is a circular import issue: 19:45:15 AttributeError: partially initialized module 'cudf' has no attribute 'dtype' (most likely due to a circular import) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for explicitly importing the object from the original subpackage
rerun tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #11680 +/- ##
===============================================
Coverage ? 86.42%
===============================================
Files ? 145
Lines ? 23014
Branches ? 0
===============================================
Hits ? 19890
Misses ? 3124
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rerun tests |
@gpucibot merge |
Description
This PR removes all excluded filename patterns from the
isort
configuration. We should runisort
on all files, and if exclusions are needed, those should be handled with action comments like# isort: skip
on a case-by-case basis (this is sometimes needed forsetup.py
to control import order with Cython / setuptools / etc.). See: https://pycqa.github.io/isort/docs/configuration/action_comments.htmlChecklist