Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isort exclusions #11680

Merged
merged 5 commits into from
Sep 19, 2022
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Sep 9, 2022

Description

This PR removes all excluded filename patterns from the isort configuration. We should run isort on all files, and if exclusions are needed, those should be handled with action comments like # isort: skip on a case-by-case basis (this is sometimes needed for setup.py to control import order with Cython / setuptools / etc.). See: https://pycqa.github.io/isort/docs/configuration/action_comments.html

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice self-assigned this Sep 9, 2022
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 9, 2022
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API. and removed Python Affects Python cuDF API. labels Sep 9, 2022
@bdice bdice marked this pull request as ready for review September 9, 2022 23:49
@bdice bdice requested review from a team as code owners September 9, 2022 23:49
@galipremsagar
Copy link
Contributor

Seems like there is a circular import issue:

19:45:15 AttributeError: partially initialized module 'cudf' has no attribute 'dtype' (most likely due to a circular import)

Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for explicitly importing the object from the original subpackage

@bdice
Copy link
Contributor Author

bdice commented Sep 14, 2022

rerun tests

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@68746ae). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7d00fb7 differs from pull request most recent head ac7f160. Consider uploading reports for the commit ac7f160 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10   #11680   +/-   ##
===============================================
  Coverage                ?   86.42%           
===============================================
  Files                   ?      145           
  Lines                   ?    23014           
  Branches                ?        0           
===============================================
  Hits                    ?    19890           
  Misses                  ?     3124           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdice
Copy link
Contributor Author

bdice commented Sep 19, 2022

rerun tests

@bdice
Copy link
Contributor Author

bdice commented Sep 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 482d8ed into rapidsai:branch-22.10 Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants