Remove unnecessary extra function for libcudacxx detection #11138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
3 - Ready for Review
harrism
approved these changes
Jun 23, 2022
robertmaynard
approved these changes
Jun 23, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11138 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22729
Branches ? 0
===============================================
Hits ? 19625
Misses ? 3104
Partials ? 0 Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can use
rapids_cpm_libcudacxxdirectly without this extra function. The only value it adds is setting theLIBCUDACXX_INCLUDE_DIRvariable, which we don't use. See also rapidsai/cuspatial#538 (comment)