Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster struct row comparator #10164

Merged
merged 58 commits into from
Mar 22, 2022
Merged

Faster struct row comparator #10164

merged 58 commits into from
Mar 22, 2022

Commits on Aug 26, 2021

  1. First commit 

    Many iterations already happened. I just realized late that I should commit
    @devavret
    devavret committed Aug 26, 2021
    Configuration menu
    Copy the full SHA
    933c974 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. testing and profiling deep single hierarchy struct

    @devavret
    devavret committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    a1636e5 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. Merge branch 'branch-22.02' into struct-row-comp

    @devavret
    devavret committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    d59f54c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-22.02' into struct-row-comp

    @devavret
    devavret committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    765dd8d View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Make the sandboxed test compile again

    @devavret
    devavret committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    3d21daf View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Update my row_comparator with nullate

    @devavret
    devavret committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    9f32e6b View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Merge branch 'branch-22.02' into struct-row-comp

    @devavret
    devavret committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    53d3c90 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Basic verticalization utility and experimental namespace

    @devavret
    devavret committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    022e2a4 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. clean up most of row operators that I didn't change.

    @devavret
    devavret committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    7fef643 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Sliced column test

    @devavret
    devavret committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    930d8de View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. column order and null precendence support

    @devavret
    devavret committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    0ecc4f8 View commit details
    Browse the repository at this point in the history

  2. Manually managed stack

    @devavret
    devavret committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    ff36d2d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. New depth based method to avoid superimpose nulls 

    sliced no longer works
    @devavret
    devavret committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    cd0f938 View commit details
    Browse the repository at this point in the history

  2. Put sort2 impl in separate TU

    @devavret
    devavret committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    7b8e060 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-22.04' into struct-row-comp

    @devavret
    devavret committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    25eb237 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Merge branch 'branch-22.04' into struct-row-comp

    @devavret
    devavret committed Feb 10, 2022
    Configuration menu
    Copy the full SHA
    d2937cf View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Move verticalization code to row_comparator.cpp

    @devavret
    devavret committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    d55c9c7 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2022

  1. Owning row lex operator

    @devavret
    devavret committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    3bd749e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. merge fixes

    @devavret
    devavret committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    613d664 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Move struct logic out of main row loop and into element_relational_co… 

    …mparator
    @devavret
    devavret committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    2ef3ac7 View commit details
    Browse the repository at this point in the history

  2. pushing even more logic into element_relational_comparator

    @devavret
    devavret committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    5577431 View commit details
    Browse the repository at this point in the history

  3. More optimizations. 

    early return and remove unnecessary statements
    @devavret
    devavret committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    f037bc0 View commit details
    Browse the repository at this point in the history

  4. review changes

    @devavret
    devavret committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    8c54a85 View commit details
    Browse the repository at this point in the history

  5. Checks to ensure tables can be compared

    @devavret
    devavret committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    9d24a87 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Another attempt at new API

    @devavret
    devavret committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    294b0cf View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2022

  1. Remove stack based struct comparator + cleanups

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    a4c799a View commit details
    Browse the repository at this point in the history

  2. thrust::pair -> cuda::std::pair

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    ecb2eb0 View commit details
    Browse the repository at this point in the history

  3. optional device spans

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    34a6564 View commit details
    Browse the repository at this point in the history

  4. Prevent device comparator construction from any table_device_view

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    fa4abb4 View commit details
    Browse the repository at this point in the history

  5. Nullate default and fix for non nested depth

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    b213210 View commit details
    Browse the repository at this point in the history

  6. Fix an unsurfaced bug about depth passing

    @devavret
    devavret committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    6f9bedd View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. Switch over sort impl to new comparator

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    be69ffa View commit details
    Browse the repository at this point in the history

  2. Copyright changes to satiate ci

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    76d535a View commit details
    Browse the repository at this point in the history

  3. Migrate struct sort benchmark to nvbench

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    78d10fc View commit details
    Browse the repository at this point in the history

  4. Avoid optional::value in favor of *

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    15920ee View commit details
    Browse the repository at this point in the history

  5. throw when trying to sort List

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    d01fc30 View commit details
    Browse the repository at this point in the history

  6. Leftover change for struct sort nvbench

    @devavret
    devavret committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    ac2eb0d View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. struct without null pushdown test

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    076c4c1 View commit details
    Browse the repository at this point in the history

  2. Remove temporary sort2_test

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    e8a9202 View commit details
    Browse the repository at this point in the history

  3. Remove temporary sort2 files

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    a4b1167 View commit details
    Browse the repository at this point in the history

  4. leftover sort2 in cmake

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    62f6914 View commit details
    Browse the repository at this point in the history

  5. cleanup benchmark headers

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    8f628ae View commit details
    Browse the repository at this point in the history

  6. Docs

    @devavret
    devavret committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    dc7d125 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. Merge branch 'branch-22.04' into struct-row-comp

    @devavret
    devavret committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    fa7d940 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Yunsong Wang <wangyunsong89@gmail.com>
    @devavret @PointKernel
    devavret and PointKernel committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    76c883f View commit details
    Browse the repository at this point in the history

  2. rmm pool in benchmark + style fixes

    @devavret
    devavret committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    98b253b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'branch-22.04' into struct-row-comp

    @devavret
    devavret committed Mar 14, 2022
    Configuration menu
    Copy the full SHA
    3255dc5 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Review changes

    @devavret
    devavret committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    52e3a35 View commit details
    Browse the repository at this point in the history

  2. More review changes

    @devavret
    devavret committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    9470f06 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Review changes req by @vyasr

    @devavret
    devavret committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    7c897c3 View commit details
    Browse the repository at this point in the history

  2. add a runtime is_relationally_comparable funtion

    @devavret
    devavret committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    e0467c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Review changes 

    - Nullate back to user provided
- const args to operator()
    @devavret
    devavret committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    fc1e993 View commit details
    Browse the repository at this point in the history

  2. Review changes

    @devavret
    devavret committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    096593f View commit details
    Browse the repository at this point in the history

  3. Avoid WAR of storing a table_device_view 

    - Add a create method to preprocessed_table that takes care of checks and copies
    @devavret
    devavret committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    f539647 View commit details
    Browse the repository at this point in the history

  4. Rename struct_linearize to decompose_structs and Improve docs

    @devavret
    devavret committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    01be0bc View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. review changes req by @ttnghia

    @devavret
    devavret committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    de95530 View commit details
    Browse the repository at this point in the history

  2. Namespace changes and making element comparator private

    @devavret
    devavret committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    6c45cd4 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Update cpp/include/cudf/table/experimental/row_operators.cuh 

    Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com>
    @devavret @vyasr
    devavret and vyasr committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    9bfd08e View commit details
    Browse the repository at this point in the history