-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CUDA_TRY macro conflicts with other RAPIDS libraries #9660
Comments
This issue has been labeled |
Still relevant and would like to see this fixed. |
Similar to #9797, we should rename to |
…DF_CHECK_CUDA. (#10589) This PR renames the `CUDA_TRY` macro to `CUDF_CUDA_TRY` to avoid name conflicts with other libraries. Resolves #9660. Similarly, `CHECK_CUDA` has been renamed to `CUDF_CHECK_CUDA`. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Hemstad (https://github.com/jrhemstad) - Jason Lowe (https://github.com/jlowe) - David Wendt (https://github.com/davidwendt) URL: #10589
Describe the bug
While trying to integrate RAPIDS RAFT and cuDF into the same application we ran across a compilation error due to a macro name conflict, e.g.:
Steps/Code to reproduce bug
Try to include raft/cudart_utils.h and cudf/utilities/error.hpp in the same compilation unit
Expected behavior
cudf macros do not conflict with definitions from other RAPIDS libraries (ideally with any library). Changing
CUDA_TRY
toCUDF_CUDA_TRY
is one potential solution.Additional context
rapidsai/raft#128 is the corresponding bug for RAFT
The text was updated successfully, but these errors were encountered: