Skip to content

Commit

Permalink
Fix rmm_mode=managed parameter for gtests(#6912)
Browse files Browse the repository at this point in the history
When using parameter `--rmm_mode=managed` for gtests `Invalid RMM allocation mode: managed` exception is thrown.
The logic in `include/cudf_test/base_fixture.hpp` is just missing a return statement.

Authors:
  - davidwendt <dwendt@nvidia.com>

Approvers:
  - Paul Taylor
  - Mark Harris

URL: #6912
  • Loading branch information
davidwendt authored Dec 7, 2020
1 parent 214dccc commit 598a14d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@

## Bug Fixes

- PR #6912 Fix rmm_mode=managed parameter for gtests


# cuDF 0.17.0 (Date TBD)

## New Features
Expand Down
2 changes: 1 addition & 1 deletion cpp/include/cudf_test/base_fixture.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ inline std::shared_ptr<rmm::mr::device_memory_resource> create_memory_resource(
if (allocation_mode == "binning") return make_binning();
if (allocation_mode == "cuda") return make_cuda();
if (allocation_mode == "pool") return make_pool();
if (allocation_mode == "managed") make_managed();
if (allocation_mode == "managed") return make_managed();
CUDF_FAIL("Invalid RMM allocation mode: " + allocation_mode);
}

Expand Down

0 comments on commit 598a14d

Please sign in to comment.