Modify test

Signed-off-by: Nghia Truong <nghiatruong.vn@gmail.com>
rapidsai · May 30, 2022 · 1e7b843 · 1e7b843
1 parent 847311b
commit 1e7b843
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/cpp/tests/lists/drop_list_duplicates_tests.cpp b/cpp/tests/lists/drop_list_duplicates_tests.cpp
@@ -204,16 +204,8 @@ TEST_F(DropListDuplicatesTest, StringTestsNonNull)
 {
   // Trivial cases - empty input.
   {
-    auto const lists    = StrListsCol{};
-    auto const expected = StrListsCol{};
-    auto const results  = cudf::lists::drop_list_duplicates(cudf::lists_column_view{lists});
-    CUDF_TEST_EXPECT_COLUMNS_EQUAL(results->view(), expected, verbosity);
-  }
-
-  // Empty input lists.
-  {
-    auto const lists    = StrListsCol{{}, {}, {}};
-    auto const expected = StrListsCol{{}, {}, {}};
+    auto const lists    = StrListsCol{{}};
+    auto const expected = StrListsCol{{}};
     auto const results  = cudf::lists::drop_list_duplicates(cudf::lists_column_view{lists});
     CUDF_TEST_EXPECT_COLUMNS_EQUAL(results->view(), expected, verbosity);
   }
@@ -327,6 +319,19 @@ TYPED_TEST(DropListDuplicatesTypedTest, TrivialInputTests)
     CUDF_TEST_EXPECT_COLUMNS_EQUAL(results_vals->view(), expected, verbosity);
   }
 
+  // All input lists are empty.
+  {
+    auto const lists    = ListsCol{ListsCol{}, ListsCol{}, ListsCol{}};
+    auto const expected = ListsCol{ListsCol{}, ListsCol{}, ListsCol{}};
+    auto const results  = cudf::lists::drop_list_duplicates(cudf::lists_column_view{lists});
+    CUDF_TEST_EXPECT_COLUMNS_EQUAL(results->view(), expected, verbosity);
+
+    auto const [results_keys, results_vals] = cudf::lists::drop_list_duplicates(
+      cudf::lists_column_view{lists}, cudf::lists_column_view{lists});
+    CUDF_TEST_EXPECT_COLUMNS_EQUAL(results_keys->view(), expected, verbosity);
+    CUDF_TEST_EXPECT_COLUMNS_EQUAL(results_vals->view(), expected, verbosity);
+  }
+
   // Trivial cases.
   {
     auto const lists    = ListsCol{0, 1, 2, 3, 4, 5};