raise setuptools floor to 61.0.0, sphinx floor to 8.0.0, other small dependencies cleanup #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
improvement
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
jameslamb
changed the title
jameslamb
changed the title
jakirkham
approved these changes
Feb 4, 2025
| # TODO: sphinx upper version limit can likely be removed after pydata 0.13 | ||
| # is released. See https://github.com/pydata/pydata-sphinx-theme/issues/1094 | ||
| - sphinx<6 | ||
| - sphinx>=8.0.0 |
There was a problem hiding this comment.
As noted in the comment, this was pinned to an old version of sphinx in PR ( #481 ) to workaround this upstream pydata-sphinx-theme issue ( pydata/pydata-sphinx-theme#1094 )
Looks like that issue was subsequently fixed in PR ( pydata/pydata-sphinx-theme#1097 ) as part of pydata-sphinx-theme's 0.13.0 release
Given that has been out for a while (and several versions have since been released), think we are ok dropping it
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#146
setuptoolsdependency to>=61.0.0(the first version to supportpyproject.toml)numpydocpins in testing and docs the samesphinx, changessphinxdependency to>=8.0.0(matching what was recently done across the RAPIDS, e.g. in Remove sphinx pinning cuml#6195)numpydocmakes it intorequirementsoutput fromrapids-dependency-file-generator