Fix CUDA trove classifiers & update README install instructions #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
bug
gigony
approved these changes
Feb 7, 2024
There was a problem hiding this comment.
Thanks @jakirkham !
Looks good to me!
I didn't know that the classifier doesn't accept minor version .x
|
They do, but then they have to be written differently (for example), but they have to be written differently Given that thought it was simpler to go with the major only approach. The wheels are just built for the CUDA major version anyways |
jakirkham
changed the title
grlee77
reviewed
Feb 7, 2024
grlee77
approved these changes
Feb 7, 2024
raydouglass
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CUDA trove classifiers to match CUDA 11 and CUDA 12
Also update the README's install instructions for CUDA 11.2+ and CUDA 12