Fix iterator-related memory issues #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigony
added
bug
gigony
force-pushed
the
fix_iterator_issues
branch
2 times, most recently
from
632588d
to
293f104
Compare
grlee77
approved these changes
Oct 27, 2023
python/cucim/tests/performance/clara/test_read_region_memory_usage.py
Outdated
Show resolved
Hide resolved
|
Have merged PR: #618 Looks like there are some conflicts |
Signed-off-by: Gigon Bae <gbae@nvidia.com>
GIL is not acquired when using Python object. Signed-off-by: Gigon Bae <gbae@nvidia.com>
- Return a shared pointer of CuImageIterator, taking ownership of CuImageIterator instance, instead of returning a copy of CuImageIterator - Do not create new instance for CuImageIterator when __iter__ is called. Instead, return self. - Wait until all threads are finished in ThreadBatchDataLoader destructor Signed-off-by: Gigon Bae <gbae@nvidia.com>
- Throw StopIteration exception early
- Do not set nullptr for 'raster_data_' in
ThreadBatchDataLoader::next_data()
- Setting nullptr prevents freeing memory in the destructor
of ThreadBatchDataLoader
Signed-off-by: Gigon Bae <gbae@nvidia.com>
gigony
force-pushed
the
fix_iterator_issues
branch
from
293f104
to
cb03761
Compare
jakirkham
approved these changes
Oct 30, 2023
|
/merge |
|
I am seeing an error message regarding cpu memory usage: It is likely that it is intermittent issue (may need to increase the threshold > 1273671680 - 1223131136 = 50540544). |
|
Thanks Gigon! 🙏 Should we file a follow-up issue or PR? |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 31, 2023
…est (#623) There is a case where memory usage check is not stable enough: #620 (comment) Instead of choosing index 1 and 4 (among 5 samples), choose 5 and 9 (among 10 samples) for memory leak check. Authors: - Gigon Bae (https://github.com/gigony) Approvers: - Gregory Lee (https://github.com/grlee77) URL: #623
Filed as issue: #625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MERGE after #618
Fix memory corruption issue in ThreadBatchDataLoader
Fix #592
__iter__is called. Instead, return self.Fix memory leak in ThreadBatchDataLoader
Fix #598
raster_data_inThreadBatchDataLoader::next_data()Fix fatal errors for cache object
Add iterator-related test cases for memory issue