Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packages (pybind11 and catch2) and do not use nvidia-docker command #618

Merged
merged 5 commits into from
Oct 30, 2023

Commits on Oct 26, 2023

  1. Update Catch2 to v3.4.0

    Without upgrading Catch2, The following error occurs when building on
    Ubuntu 22.04 due to glibc:
    
    cucim/build-debug/_deps/deps-catch2-src/single_include/catch2/
    catch.hpp:10830:58: error: call to non-‘constexpr’ function
    ‘long int sysconf(int)’
    10830 |     static constexpr std::size_t sigStackSize = 32768 >=
                    MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
    
    Signed-off-by: Gigon Bae <gbae@nvidia.com>
    gigony committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    3af33ed View commit details
    Browse the repository at this point in the history
  2. Update pybind11 to v2.11.1

    This PR updates pybind11 to v2.11.1.
    
    Even with the latest version of pybind11, we still have an issue
    with `pybind11::array_t` when cuCIM is used in multithread without
    importing numpy in the main thread.
    
    pybind/pybind11#4877
    
    Will need to wait for the next release of pybind11.
    
    Signed-off-by: Gigon Bae <gbae@nvidia.com>
    gigony committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    39a7348 View commit details
    Browse the repository at this point in the history
  3. Use runtime option instead of using nvidia-docker command

    nvidia-docker binary is not available if user doesn't install
    nvidia-docker2 package. This change uses runtime option instead
    of using nvidia-docker command.
    
    Signed-off-by: Gigon Bae <gbae@nvidia.com>
    gigony committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    4b3d3b8 View commit details
    Browse the repository at this point in the history
  4. Apply pybind11 patch to avoid deadlock

    This applies the following patches to pybind11:
    
    - pybind/pybind11#4857
    - pybind/pybind11#4877
    
    to avoid deadlock when using pybind11 without importing numpy in
    multi-threaded environment.
    gigony committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    44dc3d0 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Configuration menu
    Copy the full SHA
    64938e4 View commit details
    Browse the repository at this point in the history