Implement additional deprecations carried out for scikit-image 0.20 #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skimage 0.20 will also remove selem and a few other arguments, but we had previously scheduled those for removal in cucim 2023.02.00, so will stick to that schedule fix version string comparison in existing _denoise_wavelet utility in test_j_invariant.py
grlee77
added
breaking
|
These deprecations have been approved, but not yet merged upstream. See comment here: scikit-image/scikit-image#6583 (comment) I think it would be nice to not have all of these deprecated parameters around, but am also okay if we want to bump this until 2022.02.00. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #419
This PR removes most of the deprecated parameters that are being removed in scikit-image 0.20.
There are a few exceptions (e.g.
selem) where they will be removed in scikit-image 0.20, but we had previously advertised a specific removal date like2022.03.02. For those, I will delay the removal until the previously advertised release.It will be nice to be rid of all the deprecated
multichannelcode! The first, large commit here is just the multichannel deprecation. The rest of the commits are much smaller.