analytical moments computations, support pixel spacings in moments and regionprops #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bypass duplicate computation of moments Fast, analytical computation is available for order < 4 in 2D and 3D
deprecate neighbourhood kwarg in perimeter raise more informative error message of required intensity image was not provided
grlee77
added
improvement
grlee77
changed the title
The CUDA kernel does not compute values for orders larger than the requested one, so these remain nan in the output array.
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #419
This PR ports features related to image moments and
regionpropsfrom scikit-image 0.20 to cuCIMcucim.skimage.measure.moments_centralby ~2x by avoiding redundant computations (adaptation of Avoid redundant computations during central moments calculation scikit-image/scikit-image#6188 to the GPU)spacingof the following functions inskimage.measure:regionprops,regionprops_table,moments,moments_central,moments_normalized,centroid,inertia_tensor, andinertia_tensor_eigvals(Add spacing to regionprops and moments. scikit-image/scikit-image#6296)skimage.measure.regionprops:area,area_bbox,centroid,area_convex,extent,feret_diameter_max,area_filled,inertia_tensor,moments,moments_central,moments_hu,moments_normalized,perimeter,perimeter_crofton,solidity,moments_weighted_central, andmoments_weighted_hu. (Add spacing to regionprops and moments. scikit-image/scikit-image#6296)intensity_imagescikit-image/scikit-image#6584).