-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cucim.skimage.feature.match_descriptors #338
Add cucim.skimage.feature.match_descriptors #338
Conversation
The acceleration provided here will depend on the number and size of the descriptors. Running scikit-image's SIFT on the small When cross_check=False, max_distance=np.inf, max_ratio = 1.0 When cross_check=True, max_distance=np.inf, max_ratio = 1.0 When cross_check=False, max_distance=100.0, max_ratio < 1.0 In the latter two cases there are progressively more logical comparisons and indexing operations which end up reducing the overall acceleration factor as compared to the first case without any additional checks. |
Moved to 22.10 There's not a project board for this yet. So moved to feature planning for now. Can update that later |
Removing |
Yeah I accidentally got 21.10 the first time 🤦♂️ Sorry for the noise 😞 Should be fixed now 🍀 |
This PR now has that same issue we saw previously where the
I need to look into how we are doing the install when testing on CI. Perhaps the files are there during build but are getting omitted somehow during the package install stage? That doesn't really make sense to me, though, since it did pass previously in the branch-22.08 PR |
rerun tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you Greg!
@gpucibot merge |
closes #193
This PR adds
cucim.skimage.feature.match_descriptors
. It is a very straightforward adaptation of the scikit-image code, only substituting numpy->cupy. The only differences of note are:cdist
on the CPUThis PR also removes the deprecated
masked_register_translation
andregister_translation
(these were moved to cucim.skimage.registration.phase_cross_correlation) from the
feature` module. Removing those was missed when previously updating the API here to match scikit-image 0.19.