Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not suggest use of black in contributing guide #15

Merged

Conversation

grlee77
Copy link
Contributor

@grlee77 grlee77 commented Apr 19, 2021

I think we still have black intentionally disabled here (to make comparison to upstream scikit-image code easier).

We have disabled black on CI to make it easier to compare the cucim.skimage Python source
code to upstream scikit-image (where black has not been applied)
@grlee77 grlee77 added the doc Improvements or additions to documentation label Apr 19, 2021
@grlee77 grlee77 requested a review from a team as a code owner April 19, 2021 20:35
@grlee77 grlee77 added the non-breaking Introduces a non-breaking change label Apr 19, 2021
Copy link
Contributor

@gigony gigony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jakirkham
Copy link
Member

rerun tests

@jakirkham
Copy link
Member

jakirkham commented May 5, 2021

It would be good to fix black support in the future, but this seems fine for now

Edit: Raised as issue ( #23 )

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fd8b325 into rapidsai:branch-0.20 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants