Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yq to images #30

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Add yq to images #30

merged 2 commits into from
Dec 31, 2022

Conversation

ajschmidt8
Copy link
Member

This PR adds yq to our CI images.

This PR adds [yq](https://github.com/mikefarah/yq) to our CI images.
I removed this previously because I was under the impression that QEMU jobs will eventually complete even if they take a while.

However, I was proven wrong in the workflow run below, where the workflow timed out after 6 hours due to a QEMU build taking to long.

https://github.com/rapidsai/ci-imgs/actions/runs/3767855767/jobs/6405791187

This commit adds the `timeout-minutes` field back with a value that is generous enough to allow most jobs to complete.
@ajschmidt8 ajschmidt8 merged commit 706b561 into rapidsai:main Dec 31, 2022
@ajschmidt8 ajschmidt8 deleted the add-yq branch December 31, 2022 18:51
ajschmidt8 added a commit to rapidsai/gha-tools that referenced this pull request Dec 31, 2022
This PR adds a new script, `rapids-check-pr-job-dependencies`.

This script is intended to be used in a new check job in the
`shared-action-workflows` repository.

The script checks the `pr-builder` job in the `pr.yaml` workflow file to
ensure that it depends on all of the other jobs in the workflow file.

This is necessary because our branch protections are configured to
depend on the `pr-builder` job, so it's implied that that job will
depend on all of the other jobs in the workflow.

Depends on rapidsai/ci-imgs#30.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant