-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] Region select #738
Open
Jade-GG
wants to merge
12
commits into
master
Choose a base branch
from
feature/region-select
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[3.x] Region select #738
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5763030
Add region select
Jade-GG b38d5db
Add region select functionality
Jade-GG fe7f120
Apply fixes from Prettier
Jade-GG 51d0cc1
Add missing translation
Jade-GG ffaedfd
Merge branch 'feature/region-select' of https://github.com/rapidez/co…
Jade-GG bf7166e
Update resources/views/components/input/select/region.blade.php
Jade-GG 0b56e29
Update resources/views/components/input/select/region.blade.php
Jade-GG 8faae94
Listen to display_all & fix required always showing
Jade-GG ba73052
Merge branch 'feature/region-select' of https://github.com/rapidez/co…
Jade-GG d0c685e
Remove default
Jade-GG fa23e69
Reordered if checks
indykoning 965cf9a
Sort by name
Jade-GG File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -61,7 +61,7 @@ fragment cart on Cart { | |
street | ||
city | ||
region { | ||
code | ||
region_id | ||
label | ||
} | ||
postcode | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
@props(['country']) | ||
<graphql | ||
v-if="{{ $country }}" | ||
query="query country($id: String) { country(id: $id) { available_regions { code id name } } }" | ||
v-bind:variables="{ id: {{ $country }} }" | ||
v-bind:cache="'regions_' + {{ $country }}" | ||
v-bind:key="{{ $country }}" | ||
> | ||
<div class="contents" slot-scope="{ data }"> | ||
<template v-if="data && data.country.available_regions"> | ||
<x-rapidez::input.select | ||
{{ $attributes }} | ||
v-if="{{ Rapidez::config('general/region/display_all', '0') }} || '{{ Rapidez::config('general/region/state_required') }}'.split(',').includes({{ $country }})" | ||
v-bind:required="'{{ Rapidez::config('general/region/state_required') }}'.split(',').includes({{ $country }})" | ||
> | ||
<option v-for="region in data.country.available_regions" :value="region.id"> | ||
Jade-GG marked this conversation as resolved.
Show resolved
Hide resolved
|
||
@{{ region.name }} | ||
</option> | ||
</x-rapidez::input.select> | ||
</template> | ||
</div> | ||
</graphql> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're using
toSorted()
at the region select;Object.values().sort()
here, cleaner to do the same everywhere?