Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom shadow colors #723

Merged
merged 7 commits into from
Mar 5, 2025
Merged

Conversation

Roene-JustBetter
Copy link
Member

Removed the shadow from the minicart as it looks a bit strange together with the border.

Before:
Scherm­afbeelding 2025-02-06 om 10 39 43

After:
Scherm­afbeelding 2025-02-06 om 10 35 49

@royduin
Copy link
Member

royduin commented Feb 6, 2025

Maybe double check all uses of shadow, how was this before? A bit of shadow could be nice. Check with @jordythevulder?

@Roene-JustBetter
Copy link
Member Author

Maybe double check all uses of shadow, how was this before? A bit of shadow could be nice. Check with @jordythevulder?

I will check it with @jordythevulder the issue with the shadow is that the colors we used are to dark. I have updated the colors to lighter variants in the color palette.

New shadow color:
Scherm­afbeelding 2025-02-10 om 10 02 42

Old shadow color:
Scherm­afbeelding 2025-02-10 om 10 08 47

@royduin
Copy link
Member

royduin commented Feb 11, 2025

@royduin royduin changed the title Remove shadow from minicart Remove shadow colors Mar 5, 2025
@royduin
Copy link
Member

royduin commented Mar 5, 2025

We're removing the shadow colors as they're not changed that often. The problem with this implementation was that there wasn't a opacity defined, resulting in ugly big shadows.

We do have a Tailwind play "playground" here: https://play.tailwindcss.com/lyreLA2s54?file=config.

If you do need to change the shadow; we recommend to change the whole box shadows, not the shadow colors as this isn't a separated thing in CSS. If you just need to change some shadow colors; use the default Tailwind utilities.

@royduin royduin changed the title Remove shadow colors Remove custom shadow colors Mar 5, 2025
@royduin royduin merged commit 56607dd into master Mar 5, 2025
12 checks passed
@royduin royduin deleted the feature/minicart-without-shadow branch March 5, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants