Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement teleport in slideover #703

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

indykoning
Copy link
Member

This PR changes the global slideover to use the Teleport component so plain html can be passed without trouble

@indykoning indykoning requested a review from royduin as a code owner January 14, 2025 14:34
@royduin
Copy link
Member

royduin commented Jan 15, 2025

You're happy with the result? Should we have some docs on this? What's the simplest example how to use it?

@royduin royduin requested a review from Jade-GG January 15, 2025 13:01
@indykoning
Copy link
Member Author

Yes, i'm quite content with the result. With no workarounds being necessary to properly render the html!
A simple example is already provided at the top of the global slideover component: https://github.com/rapidez/core/blob/master/resources/views/components/slideover/global.blade.php

We could add docs, though we do not currently do that for other components

@royduin royduin merged commit f2d8a08 into master Jan 24, 2025
11 of 12 checks passed
@royduin royduin deleted the feature/teleport-global-slideover branch January 24, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants