Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] At least return something when there is a value attached to the option #520

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Jun 26, 2024

see #519

@royduin
Copy link
Member

royduin commented Aug 14, 2024

Do you have a bit more info and a good squash commit message?

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Aug 14, 2024

Do you have a bit more info and a good squash commit message?

Some custom types of options (e.g. custom product options created by expivi) would not work well in the old situation---see the old PR linked in the message. Always attempt to decode attribute value is what that one was described as, which makes sense to me.

@royduin royduin merged commit 77cc081 into master Aug 14, 2024
@royduin royduin deleted the return-something-2-x branch August 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants