Refactored module, use graphql #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indykoning
reviewed
Apr 8, 2024
resources/js/stores/useCompare.js
Outdated
| return; | ||
| } | ||
|
|
||
| let response = await magentoGraphQL("query($uid: ID!) { compareList(uid: $uid) { uid item_count attributes { code label } items { uid product { sku name url_key image { url label } } attributes { code value } } } }", { |
There was a problem hiding this comment.
So we don't acidentally mismatch the data i think we should extract the compareList data into it's own variable like we have done for the cart in the core
https://github.com/rapidez/core/blob/a8a399077136af19acb4edda4fdae2a8171f125e/resources/js/stores/useCart.js#L23
https://github.com/rapidez/core/blob/a8a399077136af19acb4edda4fdae2a8171f125e/src/Http/ViewComposers/ConfigComposer.php#L45
| } | ||
|
|
||
| export const clear = async function () { | ||
| compare.value = {} |
There was a problem hiding this comment.
Does this mean we want to call https://developer.adobe.com/commerce/webapi/graphql/schema/products/mutations/delete-compare-list/
as well? or purely client side?
jbclaudio
approved these changes
Apr 9, 2024
royduin
reviewed
Apr 23, 2024
| @@ -0,0 +1,3 @@ | |||
| <?php | |||
|
|
|||
| Route::view(config('rapidez.compare.route'), 'rapidez-compare::compare')->name('rapidez-compare::compare'); | |||
There was a problem hiding this comment.
Is prefixing the route name like views a common thing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.