Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Listen to magento config for newsletter visibility #157

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

Jade-GG
Copy link
Collaborator

@Jade-GG Jade-GG commented Dec 11, 2024

Previously the only way to get rid of the newsletter was to overwrite the templates.

@indykoning
Copy link
Member

Is showing the newsletter at X but not Y something that happens a lot?
We might simply want to listen to the Magento config to show/hide the newletter instead
image

@Jade-GG Jade-GG changed the title [3.x] Add config option for newsletter visibility [3.x] Listen to magento config for newsletter visibility Dec 13, 2024
@royduin
Copy link
Member

royduin commented Dec 17, 2024

We also need this config within the docs: https://docs.rapidez.io/3.x/configuration.html#magento-configuration

@Jade-GG
Copy link
Collaborator Author

Jade-GG commented Dec 17, 2024

We also need this config within the docs: https://docs.rapidez.io/3.x/configuration.html#magento-configuration

rapidez/docs#68

@royduin royduin merged commit 8f656c4 into master Dec 17, 2024
1 check failed
@royduin royduin deleted the feature/config-newsletter branch December 17, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants