Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components preview layout & Update screenshots #18

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Roene-JustBetter
Copy link
Member

  • I have changed the layout for the component preview / components.
  • Moved prose to the bottom of the preview.
  • Added disabled variants for components

See screenshot below:

Scherm­afbeelding 2025-01-17 om 12 52 13
Scherm­afbeelding 2025-01-17 om 12 52 25
Scherm­afbeelding 2025-01-17 om 12 52 36

@@ -6,4 +6,4 @@
<x-rapidez::input.checkbox.base />
```
--}}
<input type="checkbox" {{ $attributes->twMerge('cursor-pointer border border-default rounded-md size-5 text focus:outline-none focus:ring-0 focus:ring-offset-0') }} />
<input type="checkbox" {{ $attributes->twMerge('cursor-pointer border border-default rounded-md size-5 text focus:outline-none focus:ring-0 focus:ring-offset-0 disabled:cursor-not-allowed disabled:bg-muted disabled:border-muted') }} />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component did not have a disabled style.

@@ -6,4 +6,4 @@
<x-rapidez::input.radio.base />
```
--}}
<input type="radio" {{ $attributes->twMerge('cursor-pointer border border-default size-5 text focus:outline-none focus:ring-0 focus:ring-offset-0') }} />
<input type="radio" {{ $attributes->twMerge('cursor-pointer border border-default size-5 text focus:outline-none focus:ring-0 focus:ring-offset-0 disabled:cursor-not-allowed disabled:bg-muted disabled:border-muted') }} />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component did not have a disabled style.

@royduin royduin merged commit 9bcac78 into master Jan 21, 2025
1 check passed
@royduin royduin deleted the feature/improve-components-preview branch January 21, 2025 08:33
@royduin
Copy link
Member

royduin commented Jan 21, 2025

Merged but still needs a review @jordythevulder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants