Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slideover component #10

Merged
merged 9 commits into from
Dec 4, 2024
Merged

Add slideover component #10

merged 9 commits into from
Dec 4, 2024

Conversation

JimmyHoenderdaal
Copy link
Member

@JimmyHoenderdaal JimmyHoenderdaal commented Dec 3, 2024

Not sure what to use for the overlay color, we changed bg-emphasis to a fitting color
maybe background overlay would be a better name?

@royduin
Copy link
Member

royduin commented Dec 4, 2024

  • The demo will be automatically updated after the merge, you don't have to commit it.
  • There is a merge conflict
  • A bit of info with some links to the files in the readme would be nice

@JimmyHoenderdaal
Copy link
Member Author

  • The demo will be automatically updated after the merge, you don't have to commit it.
  • There is a merge conflict
  • A bit of info with some links to the files in the readme would be nice

Fixed the conflict
shouldn't the demo be in the gitignore then?

@JimmyHoenderdaal
Copy link
Member Author

  • The demo will be automatically updated after the merge, you don't have to commit it.
  • There is a merge conflict
  • A bit of info with some links to the files in the readme would be nice

the bot added the demo btw haha

@royduin
Copy link
Member

royduin commented Dec 4, 2024

I'll merge it, but 1 thing left: the z-indexes. Let's also apply this: rapidez/core#625 here with an updated readme to include the variables within the tailwind.config.js. Could you arrange that in a new PR @JimmyHoenderdaal?

@royduin royduin merged commit 194936a into master Dec 4, 2024
1 check passed
@royduin royduin deleted the feature/slideover branch December 4, 2024 15:53
@royduin
Copy link
Member

royduin commented Dec 11, 2024

Now this is merged; this needs te be replaced within Rapidez? See: https://github.com/rapidez/core/tree/master/resources/views/components/slideover. Could you arrange that @JimmyHoenderdaal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants