Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SNI support for Linux systems #269

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

jiakun02
Copy link
Contributor

@jiakun02 jiakun02 commented Dec 7, 2024

This has been discussed and explained with smcintyre-r7 here, please see here
rapid7/metasploit-framework#19680

@smcintyre-r7 smcintyre-r7 self-assigned this Dec 9, 2024
@smcintyre-r7 smcintyre-r7 changed the base branch from 6.x to master December 9, 2024 15:15
Copy link
Contributor

@smcintyre-r7 smcintyre-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into and fixing this. I was able to confirm this pretty quickly using wireshark. In the output from the screenshot, you'll see the top two Client Hello frames from the old Meterpreter without the SNI flag and the rest from the new build with the SNI flag. In both cases, the following command was used to start the connection.

./mettle --uri https://sni.lab.zerosteiner.com:443 --debug 2

image

I also found this information about how mbedtls handles SNI.

We don't support reverse_https stagers for the Mettle builds so this should be all that's necessary to support SNI for the Linux Meterpreters. Whether or not the other Meterpreters support it is another question entirely.

I also changed the branch from 6.x to master which is what we're using now. The old 6.x branch was for the breaking changes we were working on when developing 6.0 many years ago.

@smcintyre-r7 smcintyre-r7 merged commit 81a1715 into rapid7:master Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants