Update nokogiri dependency #19867
Merged
Update nokogiri dependency #19867
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
update-nokogiri-dependency
branch
from
e6fbf79 to
ad8c1c3
Compare
adfoster-r7
commented
Feb 7, 2025
| @@ -66,7 +66,7 @@ jobs: | |||
| - windows-2019 | |||
| - ubuntu-20.04 | |||
| ruby: | |||
| - 3.1.5 | |||
| - '3.2' | |||
There was a problem hiding this comment.
Aligning with our top level .ruby-version
sjanusz-r7
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Passing CI and working locally:
➜ metasploit-framework git:(ad8c1c3f43) ✗ bundle
Fetching gem metadata from https://rubygems.org/..........
Fetching nokogiri 1.18.2 (x86_64-darwin)
Installing nokogiri 1.18.2 (x86_64-darwin)
Bundle complete! 18 Gemfile dependencies, 220 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
1 installed gem you directly depend on is looking for funding.
Run `bundle fund` for details
➜ metasploit-framework git:(ad8c1c3f43) ✗ bundle exec msfconsole -q
[*] New in Metasploit 6.4 - The CreateSession option within this module can open an interactive session
msf6 auxiliary(scanner/smb/smb_login) >
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update nokogiri dependency
Verification
Ensure CI passes