-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weekly Updater Action #19779
Weekly Updater Action #19779
Conversation
Merged in those two pre-requisite PRs now, thanks! Looks like there's a small merge conflict for this PR to resolve 🤞
|
I wanted to keep attribution (and history) on the My dev box is down for the day, so if you want to resolve that it should be trivial with that workflow. If not, I can take care of it in like 25hrs or so |
0b5ff81
to
967c9b3
Compare
Not sure if the restriction has change, github actions were previously restricted from opening PRs in the R7 org. |
Hey @jmartin-tech, great to hear from you :) Thanks for the heads up. I double checked with PD and github actions are restricted from opening PRs in private R7 repos but not public repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I've run all the updater scripts locally, reviewed the PR this action created in your fork also verified that Github actions are able to create PRs in this repo.
One minor question and then I think this is good to land so it can create a PR this coming Monday 🎉
Co-authored-by: jheysel-r7 <Jack_Heysel@rapid7.com>
accepted! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really appreciate you adding this workflow in @h00die, I was unaware these update scripts were being neglected. Looking forward to seeing the PR Monday.
Release NotesAdds a Github workflow to run update_wordpress_vulnerabilities.rb, update_user_agent_strings.rb and update_joomla_components.rb and to post a weekly PR with the changes from each update script. This also converts both update_joomla_components and update_user_agent_strings from python scripts to ruby scripts. |
Fixes #18120
This PR gets us inline for having weekly updates to data files and external files. We do this with the following changes:
-h
, descriptions, outputs, etcWhy is this important?
Here's an example PR that gets submitted: h00die#32