Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Updater Action #19779

Merged
merged 4 commits into from
Feb 5, 2025
Merged

Weekly Updater Action #19779

merged 4 commits into from
Feb 5, 2025

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Dec 30, 2024

Fixes #18120

This PR gets us inline for having weekly updates to data files and external files. We do this with the following changes:

  1. Update UA string updater python script to ruby
  2. Update joomla component gatherer python script to ruby
  3. Sync all the ruby update scripts with -h , descriptions, outputs, etc
  4. build a github workflow which runs weekly, runs the update scripts, and submits a PR with the changes

Why is this important?

Here's an example PR that gets submitted: h00die#32

@h00die h00die changed the title weekly updater action Weekly Updater Action Dec 30, 2024
@h00die
Copy link
Contributor Author

h00die commented Jan 1, 2025

Whoever is assigned this, I would suggest landing #19755 and #19774 first, or closing those out as this will supersede them in a week.

@adfoster-r7
Copy link
Contributor

Merged in those two pre-requisite PRs now, thanks!

Looks like there's a small merge conflict for this PR to resolve 🤞

Conflicting files
tools/dev/update_user_agent_strings.py

@h00die
Copy link
Contributor Author

h00die commented Jan 1, 2025

I wanted to keep attribution (and history) on the .py files, so the workflow was git mv <name>.py <name>.rb, then overwrite the content with a ruby version.

My dev box is down for the day, so if you want to resolve that it should be trivial with that workflow. If not, I can take care of it in like 25hrs or so

@h00die h00die force-pushed the action_update_weekly branch from 0b5ff81 to 967c9b3 Compare January 2, 2025 03:35
@jmartin-tech
Copy link
Contributor

Not sure if the restriction has change, github actions were previously restricted from opening PRs in the R7 org.

@jheysel-r7 jheysel-r7 self-assigned this Feb 3, 2025
@jheysel-r7
Copy link
Contributor

Not sure if the restriction has change, github actions were previously restricted from opening PRs in the R7 org.

Hey @jmartin-tech, great to hear from you :)

Thanks for the heads up. I double checked with PD and github actions are restricted from opening PRs in private R7 repos but not public repos.

Copy link
Contributor

@jheysel-r7 jheysel-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I've run all the updater scripts locally, reviewed the PR this action created in your fork also verified that Github actions are able to create PRs in this repo.

One minor question and then I think this is good to land so it can create a PR this coming Monday 🎉

Co-authored-by: jheysel-r7 <Jack_Heysel@rapid7.com>
@h00die
Copy link
Contributor Author

h00die commented Feb 4, 2025

accepted!

Copy link
Contributor

@jheysel-r7 jheysel-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate you adding this workflow in @h00die, I was unaware these update scripts were being neglected. Looking forward to seeing the PR Monday.

@jheysel-r7 jheysel-r7 merged commit deef85d into rapid7:master Feb 5, 2025
82 checks passed
@jheysel-r7 jheysel-r7 added the rn-enhancement release notes enhancement label Feb 5, 2025
@jheysel-r7
Copy link
Contributor

Release Notes

Adds a Github workflow to run update_wordpress_vulnerabilities.rb, update_user_agent_strings.rb and update_joomla_components.rb and to post a weekly PR with the changes from each update script. This also converts both update_joomla_components and update_user_agent_strings from python scripts to ruby scripts.

@h00die h00die deleted the action_update_weekly branch February 5, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement rn-enhancement release notes enhancement
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Automate Updates for Data Frequently Updated
4 participants