-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump IRB #19709
base: master
Are you sure you want to change the base?
Bump IRB #19709
Conversation
Reasoning for this bump:
|
Hey @szymonj99, thanks for the update. I was able to follow the testing steps and everything looks almost good to go. I was seeing this following warning when starting up
|
@jheysel-r7 Thank you! I will look into that and see what I can do 👍 I am experiencing rubygems.org issues right now, and will come back to this tomorrow. It seems like, after some local Docker testing, this PR would need to wait until we bump to around Ruby 3.4.1, as that's when the warning disappeared. Either that, or we need to run |
CC: @jheysel-r7 After some testing with Docker: 3.2.5
Results in the StringIO warning:
After running
3.4.1
Results in no StringIO warning:
|
Hey @szymonj99, We appreciate you investigating this issue! Waiting for MSF to switch to a higher Ruby seems reasonable to me 👍 I'll add the blocked label on this PR for now and will circle back when the time comes. |
This PR bumps the IRB version.
Since Framework is now using 3.2.5, it is safe to unpin and bump IRB as per the original thread: #18432 (comment)
Verification
msfconsole
irb
session -i -1
irb