Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the DRuby remote code execution module #14335

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

zeroSteiner
Copy link
Contributor

@zeroSteiner zeroSteiner commented Nov 2, 2020

This removes the DRuby RCE module (exploit/linux/misc/drb_remote_codeexec).

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • See that the module is no longer present

@adfoster-r7
Copy link
Contributor

@zeroSteiner Is there a reason for the module deletion? I'm happy to ship this PR - just wanting to lay breadcrumbs down for historical context 😄

@zeroSteiner
Copy link
Contributor Author

A vulnerability was disclosed to use regarding this module. While #14300 fixed instances where an arbitrary third party attacker could exploit Metasploit Framework users who had run this module and inadvertently started a DRuby service of their own, I failed to address the scenario where the server targeted by the Metasploit Framework user was malicious. In this second case, this module poses a threat in that the malicious server that is targeted could exploit the running instance of Metasploit to gain code execution within the context of the user running Metasploit. I looked into fixing it without removing the module but was unable to find a way to configure an allowlist of input items for processing. It's likely that a proper solution would involve a lower level implementation of the DRuby stack that's not easily provided through Ruby's API. This didn't seem like it was worth the effort and time it would take for this particular module as the vulnerability would still be present while that development was underway.

@bwatters-r7 bwatters-r7 self-assigned this Nov 2, 2020
Copy link
Contributor

@adfoster-r7 adfoster-r7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context, LGTM! 👍

@bwatters-r7 bwatters-r7 merged commit 8add7fb into rapid7:master Nov 3, 2020
@bwatters-r7 bwatters-r7 added the rn-no-release-notes no release notes label Nov 3, 2020
@todb-r7
Copy link

todb-r7 commented Nov 6, 2020

Say, can you peek at rapid7/cvelist#39 and see if that description and title reads right to you, @zeroSteiner and/or @bwatters-r7 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants