Correct module resolution and fix javadoc.

raphw · Apr 26, 2022 · 4c470e2 · 4c470e2
1 parent d05c47d
commit 4c470e2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/byte-buddy-agent/pom.xml b/byte-buddy-agent/pom.xml
@@ -157,7 +157,6 @@
                     <exports>${packages.list}</exports>
                     <requires>java.instrument</requires>
                     <static-requires>
-                        java.management,
                         jdk.attach,
                         com.sun.jna,
                         com.sun.jna.platform

diff --git a/byte-buddy-agent/src/main/java/net/bytebuddy/agent/ByteBuddyAgent.java b/byte-buddy-agent/src/main/java/net/bytebuddy/agent/ByteBuddyAgent.java
@@ -1324,7 +1324,9 @@ public String resolve() {
             }
 
             /**
-             * A process provider for a legacy VM that reads the process id from its JMX properties.
+             * A process provider for a legacy VM that reads the process id from its JMX properties. This strategy
+             * is only used prior to Java 9 such that the <i>java.management</i> module never is resolved, even if
+             * the module system is used, as the module system was not available in any relevant JVM version.
              */
             protected enum ForLegacyVm implements ProcessProvider {
 

diff --git a/byte-buddy-dep/src/main/java/net/bytebuddy/utility/GraalImageCode.java b/byte-buddy-dep/src/main/java/net/bytebuddy/utility/GraalImageCode.java
@@ -161,7 +161,7 @@ public boolean isNativeImageExecution() {
     }
 
     /**
-     * A privileged action to resolve the image code via
+     * A privileged action to resolve the image code via the current JVM processes input arguments, if available.
      */
     protected enum ImageCodeContextAction implements PrivilegedAction<GraalImageCode> {
-Original file line number
+Diff line change
@@ Expand Up / @@ -161,7 +161,7 @@ public boolean isNativeImageExecution() { @@
         }
         /**
-         * A privileged action to resolve the image code via
+         * A privileged action to resolve the image code via the current JVM processes input arguments, if available.
          */
         protected enum ImageCodeContextAction implements PrivilegedAction<GraalImageCode> {
@@ Expand Down @@