Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert raw sql to sqlalchemy for standings #8

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Convert raw sql to sqlalchemy for standings #8

merged 3 commits into from
Sep 17, 2020

Commits on Sep 16, 2020

  1. query.get_standings: convert raw sql to sqlalchemy 

    in order to support more database options.

Related issue: raphattack#1

Also:
- Include ties in denominator when calculating
win percentage, average points for, and average points against
- Removes get_standings_overall in favor of get_standings
now accepting an optional year kwarg that defaults to None.
When no year/ None is provided all years are included.
    @smfarrelly
    smfarrelly committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    669172d View commit details
    Browse the repository at this point in the history

  2. query.py: fix up mypy annotations

    @smfarrelly
    smfarrelly committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    bf4fbc7 View commit details
    Browse the repository at this point in the history

  3. standings: add ties column to standings table

    @smfarrelly
    smfarrelly committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    20088cf View commit details
    Browse the repository at this point in the history