Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for M5StickC Plus2 #403

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

smart40-githib
Copy link

No description provided.

@raomin
Copy link
Owner

raomin commented Feb 26, 2024

Thanks @smart40-githib, looks good. Did you check retro compatibility with M5StickC?

@smart40-githib
Copy link
Author

Unfortunately I only have a Plus2. The changes are mainly to use the appropriate header files when configured for the Plus2 and to replace some unsupported or deprecated calls with the M5Unified equivalents. It should be backwards compatible.

From the issues page I can see that I may have to make a small change so please hold off for now.

@smart40-githib
Copy link
Author

The fix has been confirmed good in the issues topic, the pull request is good to go.

@redtree99
Copy link

Hi, Thanks for the fix. Just uploaded it and realised it isn't fully implemented yet, doh. Any idea when support for the plus2 will be in the core code?
Many Thanks!

@raomin raomin merged commit 54f8512 into raomin:main Mar 6, 2024
@raomin
Copy link
Owner

raomin commented Mar 12, 2024

Hmm M5 libs previous plus2 has no M5.Display.
Your code breaks for the other env.
Is M5.Axp.ScreenBreath(12); not working on M5StickC Plus2

@raomin
Copy link
Owner

raomin commented Mar 12, 2024

... ah, it doesn't exist on M5Stickc Plus2.
I'll make it conditional then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants