Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LTO to avoid missing symbols in some envs #415

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

amarshall
Copy link
Contributor

LTO may not always work correctly, for whatever reason, resulting in e.g.

node_modules/argon2/build/Release/argon2.node: undefined symbol: argon2_ctx

Removing LTO seems to be fine, and resolves the above issue.

LTO may not always work correctly, for whatever reason, resulting in
e.g.

> node_modules/argon2/build/Release/argon2.node: undefined symbol: argon2_ctx

Removing LTO seems to be fine, and resolves the above issue.
@ranisalt ranisalt merged commit c1f756f into ranisalt:master Aug 25, 2024
21 of 22 checks passed
@ranisalt
Copy link
Owner

Great find, thanks!

@amarshall amarshall deleted the no-lto branch August 25, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants