Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

guard against @NgModule() annotation #19

Merged
merged 1 commit into from
Sep 10, 2018
Merged

guard against @NgModule() annotation #19

merged 1 commit into from
Sep 10, 2018

Conversation

mascarenhas
Copy link
Contributor

No description provided.

@mascarenhas mascarenhas changed the title guard against @NgModule() annotation guard against @NgModule() annotation Sep 10, 2018
santiago-elustondo
santiago-elustondo approved these changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@santiago-elustondo santiago-elustondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me. there are numerous other assumptions made in these probes that we are not being defensive enough about, so i expected issues like this.

@mascarenhas mascarenhas merged commit ca11d69 into master Sep 10, 2018
@andrewthauer andrewthauer deleted the fix-issue-18 branch October 11, 2018 15:38
@andrewthauer andrewthauer added the internal PR: Internal changes only label Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@santiago-elustondo santiago-elustondo santiago-elustondo approved these changes

Assignees
No one assigned
Labels
internal PR: Internal changes only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mascarenhas @santiago-elustondo @andrewthauer