Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run short e2e tests only for code changes #737

Merged

Conversation

furkatgofurov7
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 commented Sep 9, 2024

What this PR does / why we need it:
We run e2e tests in every PR and current workflow defines the type of actions to run e2e short tests are as following:

on:
  pull_request:
    types: [opened, edited, synchronize, reopened, labeled, unlabeled]

Description of each activity type:

  • opened: Triggered when a new pull request is opened.
  • edited: Triggered when an existing pull request is edited.
  • synchronize: Triggered when a pull request's head branch is updated (e.g., new commits are pushed to the branch).
  • reopened: Triggered when a closed pull request is reopened.
  • labeled: Triggered when a label is added to a pull request.
  • unlabeled: Triggered when a label is removed from a pull request.

Personally, it seems too much to re-run whole e2e-short tests when just editing PR description or labeling/unlabeling (it does not matter for us, because we don't have a selective test mechanism based on PR labels) of PR happens (in fact it happens to me a lot and that always re-runs the job which takes as of now ~1h). So, I would like to re-run e2e-short tests only when it is required: in new/re-opened PRs, code change pushes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7 furkatgofurov7 requested a review from a team as a code owner September 9, 2024 10:47
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, it seems too much to re-run whole e2e-short tests when just editing PR description or labeling/unlabeling

Agree, LGTM, thanks!

@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) September 9, 2024 10:50
@Danil-Grigorev Danil-Grigorev merged commit ef339d9 into rancher:main Sep 9, 2024
9 checks passed
@furkatgofurov7 furkatgofurov7 deleted the e2e-test-only-run-if-needed branch September 9, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants