Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use E2E config instead of ginkgo flags #657

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

alexander-demicev
Copy link
Member

@alexander-demicev alexander-demicev commented Aug 12, 2024

What this PR does / why we need it:

  • Use e2e config instead of ginkgo flags so we can have a centralized place for managing all e2e configuration options
  • Add documentation for public structure and functions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link
Contributor

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update test/e2e/README.md with new pre-requisites to setup e2e tests?

Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Signed-off-by: Alexandr Demicev <alexandr.demicev@suse.com>
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good to me, 👍🏼 for godoc improvements

@furkatgofurov7 furkatgofurov7 merged commit 435d814 into rancher:main Aug 14, 2024
9 checks passed
@alexander-demicev alexander-demicev deleted the e2erefactoring2 branch August 14, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants