Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Perform e2e on CAAPF with hostNetwork: true #654

Merged

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Aug 8, 2024

What this PR does / why we need it:
This PR performs CNI installation using CAAPF in the child clusters, which replaces CRS usage in docker clusters in e2e suite.
This change currently requires alpha version of the rancher chart, with version above or equal to v2.9.1-alpha1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #651

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner August 8, 2024 13:05
@Danil-Grigorev Danil-Grigorev changed the title 🌱 Perform e2e on CAAPF with hostNetwork: true [WIP] 🌱 Perform e2e on CAAPF with hostNetwork: true Aug 8, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the caapf-host-network-e2e branch 2 times, most recently from 3dc9162 to e451747 Compare August 12, 2024 09:44
@Danil-Grigorev
Copy link
Contributor Author

In order to use CAAPF for deploying calico CNI as a helm chart we need to replicate the behavior for chart templating:

There is an issue for that: rancher-sandbox/cluster-api-addon-provider-fleet#32 which needs to be implemented.

@Danil-Grigorev Danil-Grigorev changed the title [WIP] 🌱 Perform e2e on CAAPF with hostNetwork: true 🌱 Perform e2e on CAAPF with hostNetwork: true Aug 12, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the caapf-host-network-e2e branch 2 times, most recently from ffceaa5 to f88de69 Compare August 12, 2024 12:43
- Install kindnet and calico CNI in the cluster using CAAPF

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@furkatgofurov7
Copy link
Contributor

I don't remember us having discussion on why using CRS should be replaced by CAAPF?
I would appreciate if we could discuss the benefits over the current CNI installation solution and why can't we have both tested in e2e tests, since CRS seem to be still relevant upstream.

@Danil-Grigorev
Copy link
Contributor Author

@furkatgofurov7 This change only adds CSI provisioning tests. CRS are tested upstream, we don’t need to duplicate this if there is an alternative. The CAAPF provides an alternative method, which does not yet have test coverage. This change adds it within turtles.

Prior approach to CAAPF is usage of CAAPH, in #448 but since Fleet is installed in every rancher cluster, we can use it to perform same functionality as CAAPH.

@furkatgofurov7
Copy link
Contributor

@furkatgofurov7 This change only adds CSI provisioning tests. CRS are tested upstream, we don’t need to duplicate this if there is an alternative. The CAAPF provides an alternative method, which does not yet have test coverage. This change adds it within turtles.

Prior approach to CAAPF is usage of CAAPH, in #448 but since Fleet is installed in every rancher cluster, we can use it to perform same functionality as CAAPH.

Alright that makes sense, by PR description I had the feeling that CRS are not relevant at all in turtles and we completely drop its usage. Using CAAPF instead of CAAPH is a good improvement towards wider adoption of CAAPF.

@alexander-demicev alexander-demicev merged commit c7850e2 into rancher:main Aug 13, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install CNI using Fleet Addon Provider
3 participants