Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Pass the new GVK flag to azure manager #646

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Aug 7, 2024

What this PR does / why we need it:

Since the introduction of the flags upstream in

And implementing upstream kubernetes-sigs/cluster-api-provider-azure#4854, we need some changes to our turtles provider.

The CAPZ supports using different GVK for establishing controller to watch over changes within the bootstrap token. With that turtles will be able to leverage this flag for any user creating azure CAPIProvider.

The default value (set to watch RKE2Config for us) of the CLI flag can be overridden, if the CAPIProvider resource has additionally specified:

spec:

  deployment:
    containers:
    - args:
        --bootstrap-config-gvk: KubeadmConfig.v1beta1.bootstrap.cluster.x-k8s.io
      name: manager

This allows to run the CAPZ with kubeadm bootstrap/controlPlane provider if required.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #633

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Copy link
Contributor

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Danil-Grigorev. I'm looking at re-enabling E2E tests for Azure after this change.

Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing it upstream and in CAPIProvider AP

@Danil-Grigorev Danil-Grigorev merged commit d6661c4 into rancher:main Aug 8, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CAPZ: pass gvk settings to deployment
3 participants