Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install cert-manager before capi-operator #636

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

yiannistri
Copy link
Contributor

What this PR does / why we need it:

The CAPI Operator Helm chart no longer installs cert-manager as a prerequisite. This PR changes the dev script to install cert-manager beforehand.

Also fixed the link to the dev guide.

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@yiannistri yiannistri requested a review from a team as a code owner August 5, 2024 19:18
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@furkatgofurov7 furkatgofurov7 enabled auto-merge (rebase) August 5, 2024 19:23
auto-merge was automatically disabled August 6, 2024 09:23

Base branch requires signed commits

@yiannistri yiannistri merged commit 7671bd0 into rancher:main Aug 6, 2024
15 of 16 checks passed
@yiannistri yiannistri deleted the fix-dev-script branch August 6, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants