Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Separate auto-migration e2e from the import tests #586

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Jun 27, 2024

What this PR does / why we need it:

Due to migration suite running together with import tests, the chart state in the same bootstrap cluster was modified from one test to another. This was causing e2e flakes, and this change should fix it.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner June 27, 2024 15:37
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the separate-migration-e2e branch 2 times, most recently from 6856817 to 0de431b Compare June 27, 2024 16:32
@furkatgofurov7
Copy link
Contributor

@Danil-Grigorev #582 is not passing with these changes on top?

@furkatgofurov7
Copy link
Contributor

I am fine merging this (since it fixes the current e2e test failure) and building on top of it the other changes

@furkatgofurov7 furkatgofurov7 enabled auto-merge (squash) June 27, 2024 20:23
@furkatgofurov7 furkatgofurov7 merged commit b759ca2 into rancher:main Jun 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants