🌱 cover cluster reimport after running e2e #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adds a re-import check after running the existing
import_gitops
suite. The validation sits behind a condition passed as inputTestClusterReimport
which is proposed to only be enabled on CAPD tests to limit the effect on running time, which is already considerably long. This is also the reason why the new re-import validation is added to an existing test suite and not as a new one.Both controller types are supported for now (v1 and v3 clusters) until we move completely to only v3.
To simplify and reduce code duplication, the validation on the Rancher cluster resource is now part of a
validateRancherCluster
function which is called during the "normal" test and then again after re-import.The process of re-import is as follows:
imported=true
.imported=true
.Which issue(s) this PR fixes:
Fixes #266
Special notes for your reviewer:
Checklist: