🌱 Revise questions.yaml and add missing options #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
12 times, most recently
from
477a625
to
eab058b
Compare
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
6 times, most recently
from
1188955
to
236f810
Compare
Danil-Grigorev
requested review from
furkatgofurov7,
alexander-demicev and
richardcase
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
from
236f810
to
4bc569b
Compare
alexander-demicev
previously approved these changes
Apr 2, 2024
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
from
4bc569b
to
9a6665d
Compare
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
2 times, most recently
from
0931565
to
6739cd1
Compare
|
Screencast from 2024-04-02 17-36-24.webm |
richardcase
reviewed
Apr 2, 2024
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
from
6739cd1
to
622bf80
Compare
richardcase
reviewed
Apr 3, 2024
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
update-questions-yaml
branch
from
622bf80
to
d21ec24
Compare
- Test install, uninstall and re-install in helm chart testing Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
furkatgofurov7
approved these changes
Apr 3, 2024
alexander-demicev
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We need to provide best UX with
questions.yamlwhile installing turtles from UI. This change refactors the manifest and adds missing helm chart options, or features which may force users to fall back to helm cli installation.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #451
Special notes for your reviewer:
Checklist: