🐛 Provider re apply tests #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
force-pushed
the
provider-re-apply-tests
branch
3 times, most recently
from
56cac58
to
636021e
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
salasberryfin
approved these changes
Mar 12, 2024
richardcase
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add logic for conditions merge on CAPIProvider resource. This fixes situation when a LastAppliedConfigurationTime is set, but is overwritten by the child CAPI Operator conditions, causing forced cleanup of annotation and infinite reconciles.
Additionally, cache re-sync time reduced to 2 minutes so that the infrastructure is re-applied periodically.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #407
Depends on #396
Special notes for your reviewer:
Checklist: