add option to specify pod selectors #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really would love to see this upstream implemented - maybe we can solve the CI issue and then reach out to the maintainers to include this change? |
dweomer
reviewed
Apr 8, 2023
Comment on lines
+267
to
+271
| if drain.PodSelector != nil { | ||
| args = append(args, "--pod-selector", `!`+upgradeapi.LabelController+`,`+*drain.PodSelector) | ||
| } else { | ||
| args = append(args, "--pod-selector", `!`+upgradeapi.LabelController) | ||
| } |
There was a problem hiding this comment.
I haven't touched Go code in nearly a year but this looks like it could be a one-liner to me.
Thank you for remembering the magic that prevents the upgrade from draining itself off of the node-to-be-upgraded!
|
Duplicate of #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve #207