scripts: improve the validate-charts scripts #7495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do not have an upper bound, we just need to ensure
the lower bound is validated.
e.g. `catalog.cattle.io/kube-version: ">= 1.18"`
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7495 +/- ##
=======================================
Coverage 23.26% 23.26%
=======================================
Files 33 33
Lines 3456 3456
=======================================
Hits 804 804
Misses 2604 2604
Partials 48 48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I was working on the same thing in #7488, but with a slightly different approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
If we do not have an upper bound, we just need to ensure the lower bound is validated.
e.g.
catalog.cattle.io/kube-version: ">= 1.18"Types of Changes
script update for CI
Verification
Harvester CSI driver uses the annotation
catalog.cattle.io/kube-version: ">= 1.18". It should pass the CI validation (for the upper bound).Should not see the warning below:
Testing
Linked Issues
User-Facing Change
Further Comments
The result of this scripts (with this PR):