Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject version requirement and bundle ID into charts #2456

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

brandond
Copy link
Member

@brandond brandond commented Feb 9, 2022

Proposed Changes

Inject version requirement and bundle ID into charts

On cluster upgrades, this will ensure that the apiserver has been restarted with the new Kubernetes version before the chart upgrade proceeds. Starting helm chart upgrades before the apiserver has been upgraded is a frequent cause of pending/failed chart upgrades, as the apiserver restart is disruptive to Helm.

This also adds a bundle-id to the chart to prevent the Rancher UI from suggesting upgrades. Manual chart upgrades should not be suggested by the Rancher UI.

Types of Changes

bugfix

Verification

  1. Create multi-node RKE2 cluster of older version
  2. Upgrade cluster to version containing this change
  3. Note that chart update jobs fail and are retried until apiserver static pods have completed their upgrade to the new RKE2 version.

Linked Issues

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 9, 2022 21:53
@brandond brandond merged commit ba9e82c into rancher:master Feb 11, 2022
@brandond brandond deleted the version_inject_charts branch June 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants