Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.6] Add ACI-CNI 6.1.1.2 variables #3766

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[release/v1.6] Add ACI-CNI 6.1.1.2 variables #3766

merged 2 commits into from
Jan 7, 2025

Conversation

akhilesh-oc
Copy link
Contributor

@akhilesh-oc akhilesh-oc commented Dec 31, 2024 •
edited
Loading

@akhilesh-oc akhilesh-oc requested a review from a team as a code owner December 31, 2024 18:43
@akhilesh-oc akhilesh-oc changed the title Add ACI-CNI 6.1.1.2 variables [release-v1.6]Add ACI-CNI 6.1.1.2 variables Dec 31, 2024
@akhilesh-oc akhilesh-oc changed the title [release-v1.6]Add ACI-CNI 6.1.1.2 variables [release/v1.6]Add ACI-CNI 6.1.1.2 variables Dec 31, 2024
@akhilesh-oc akhilesh-oc changed the title [release/v1.6]Add ACI-CNI 6.1.1.2 variables [release/v1.6] Add ACI-CNI 6.1.1.2 variables Dec 31, 2024
@mitulshah-suse
Copy link
Contributor

@akhilesh-oc Could you run go generate and commit modified data files

@vardhaman22
Copy link
Contributor

vardhaman22 commented Jan 6, 2025 •
edited
Loading

need to rerun go generate and add these files as well

 types/kdm/zz_generated_deepcopy.go
 types/zz_generated_deepcopy.go

there is a change in copyright comment in these files after doing go generate

mitulshah-suse
mitulshah-suse approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@mitulshah-suse mitulshah-suse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitulshah-suse mitulshah-suse merged commit b037618 into rancher:release/v1.6 Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitulshah-suse mitulshah-suse mitulshah-suse approved these changes

@kinarashah kinarashah kinarashah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akhilesh-oc @mitulshah-suse @vardhaman22 @kinarashah @jeffinkottaram