added --streaming-bind-addr option for cri-dockerd #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinarashah
reviewed
Aug 21, 2024
entrypoint.sh
Outdated
| @@ -115,7 +115,16 @@ if [ "$1" = "kubelet" ]; then | |||
| if [ "${RKE_KUBELET_CRIDOCKERD_DUALSTACK}" == "true" ]; then | |||
| EXTRA_FLAGS="--ipv6-dual-stack" | |||
| fi | |||
| /opt/rke-tools/bin/cri-dockerd --network-plugin="cni" --cni-conf-dir="/etc/cni/net.d" --cni-bin-dir="/opt/cni/bin" ${RKE_KUBELET_PAUSEIMAGE} --container-runtime-endpoint=$CONTAINER_RUNTIME_ENDPOINT ${EXTRA_FLAGS} & | |||
| STREAM_SERVER_ADDRESS=$(echo "$@" | grep -Eo "\-\-stream-server-address+.*" | awk '{print $1}' | cut -d "=" -f2) | |||
There was a problem hiding this comment.
Is there a PR in RKE that sets --stream-server-address from cluster.yml?
There was a problem hiding this comment.
actually i was working on that and then realised that these options can not be sent as command Args and has to be passed through environment since all the cli options are passed to kubelet command because of which kubelet startup fails.
I have updated it here and also created a rke PR accordingly.
There was a problem hiding this comment.
ya if you add it in commandArgs, it'd need to be filtered out before starting kubelet. thanks for fixing it in rke!
vardhaman22
force-pushed
the
add-stream-server-addr
branch
from
95ce5ba
to
7902ad8
Compare
vardhaman22
force-pushed
the
add-stream-server-addr
branch
from
7902ad8
to
1fdbf37
Compare
kinarashah
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues:
added --streaming-bind-addr option configuration for cri-dockerd.